Open
Conversation
added 4 commits
January 15, 2015 16:51
Use Matcher#appendReplacement() and Matcher#appendTail() to perform a single pass through the device replacement in order to avoid edge cases where the order of replacement changes the generated string.
|
Any update on this merge? |
|
+1 and LGTM. I'm looking forward to this improvement. |
|
any updates on this? |
|
Hey @tmatei @BaiGang and @mspiegel I am currently working in a project that is bases on this lib but I am trying to put things up to date. For example I have a remote url load for the yaml and a scheduled load. I added this changes also, by the end of this week I will have also public maven repos so it can be easily included in projects. I would love to hear feedback from you. |
|
why was this merge reverted? just curious, we would like to get brand and model? |
|
Could this PR be reviewed again? device brand is useful in many circumstances |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for ua-parser/uap-core@3021618.
It also cleans up the hashCode() methods for the various classes.